Answer
Internal DASD expansion is usually simpler and cheaper if the goal is just more disk pool capacity on one server. External SAN attachment makes more sense when a business wants to consolidate storage management across IBM i and other platforms on shared infrastructure.
SAN attachment adds implementation complexity, including adapter compatibility and multipathing configuration, so it should be chosen for a real consolidation or centralization goal, not simply because it sounds more modern.